Bug reports (new posts)

gimp_image_add_layer deprecated in gimp 2.7/2.8: gimp_image_add_layer deprecated in gimp 2.7/2.8

Sun, 18 Dec 2011 20:12:26 +0000

I've noticed that gimp 2.7 throws an ugly error-dialog stating that gimp-image-add-layer
is deprecated everytime the plugin tries to add a layer. I've fixed this for the fedora
package of the liquid-rescale-gimp-plugin by replacing the function calls using
the following patch:

 diff --git a/src/io_functions.c b/src/io_functions.c index 20917df..b159ed8 100644 --- a/src/io_functions.c +++ b/src/io_functions.c @@ -227,7 +227,7 @@ write_vmap_to_layer (LqrVMap * vmap, gpointer data) gimp_layer_new (image_ID, name, w, h, GIMP_RGBA_IMAGE, 100, GIMP_NORMAL_MODE); gimp_drawable_fill (seam_layer_ID, GIMP_TRANSPARENT_FILL); - gimp_image_add_layer (image_ID, seam_layer_ID, -1); + gimp_image_insert_layer (image_ID, seam_layer_ID, -1, -1); gimp_layer_translate (seam_layer_ID, x_off, y_off); if (seam_layer_p) { diff --git a/src/layers_combo.c b/src/layers_combo.c index 10d810e..e032eed 100644 --- a/src/layers_combo.c +++ b/src/layers_combo.c @@ -199,7 +199,7 @@ callback_new_mask_button (GtkWidget * button, gpointer data) gimp_layer_new (p_data->image_ID, nl_data->name, p_data->old_width, p_data->old_height, image_type, 50, GIMP_NORMAL_MODE); - gimp_image_add_layer (p_data->image_ID, layer_ID, -1); + gimp_image_insert_layer (p_data->image_ID, layer_ID, -1, -1); gimp_drawable_fill (layer_ID, GIMP_TRANSPARENT_FILL); gimp_layer_translate (layer_ID, p_data->x_off, p_data->y_off); gimp_image_undo_group_end (p_data->image_ID); diff --git a/src/render.c b/src/render.c index f50fc8c..b7e8c7e 100644 --- a/src/render.c +++ b/src/render.c @@ -172,7 +172,7 @@ render_init_carver (PlugInImageVals * image_vals, { g_snprintf (new_layer_name, LQR_MAX_NAME_LENGTH, "%s LqR", layer_name); layer_ID = gimp_layer_copy (layer_ID); - gimp_image_add_layer (image_ID, layer_ID, -1); + gimp_image_insert_layer (image_ID, layer_ID, -1, -1); gimp_drawable_set_name (layer_ID, new_layer_name); gimp_drawable_set_visible (layer_ID, FALSE); } @@ -181,7 +181,7 @@ render_init_carver (PlugInImageVals * image_vals, image_ID = gimp_image_new (old_width, old_height, gimp_image_base_type(image_ID)); gimp_image_undo_group_start(image_ID); layer_ID = gimp_layer_new_from_drawable (layer_ID, image_ID); - gimp_image_add_layer (image_ID, layer_ID, -1); + gimp_image_insert_layer (image_ID, layer_ID, -1, -1); gimp_layer_translate(layer_ID, -x_off, -y_off); gimp_drawable_set_visible (layer_ID, TRUE); if (vals->resize_aux_layers) @@ -858,7 +858,7 @@ static gboolean copy_aux_layer_to_new_image (gint32 image_ID, gint32 * layer_ID_ if (old_layer_ID) { new_layer_ID = gimp_layer_new_from_drawable (old_layer_ID, image_ID); - gimp_image_add_layer (image_ID, new_layer_ID, -1); + gimp_image_insert_layer (image_ID, new_layer_ID, -1, -1); /* gimp_drawable_offsets (old_layer_ID, &aux_x_off, &aux_y_off); */ gimp_layer_translate (new_layer_ID, -x_off, -y_off); }

Broken Link [fixed]: Re: Broken Link

Sun, 03 Jul 2011 17:57:41 +0000

I have corrected the links with the updated locations, thanks for reporting.

Broken Link [fixed]: Broken Link

Sun, 03 Jul 2011 17:41:31 +0000

I apologise if this is an incorrect place to put this.

The link to the paper by Shai Avidan and Ariel Shamir that can be found here or here are both broken.

The broken link points to here:
http://www.faculty.idc.ac.il/arik/imret.pdf

Liquid Rescale Changes Image Size [INVALID]: Re: Liquid Rescale Changes Image Size

Mon, 13 Dec 2010 12:18:31 +0000

This is not a bug: there's an option you can untick to prevent this, you find it in the Output tab. Look at the documentation for more help.

Liquid Rescale Changes Image Size [INVALID]: Liquid Rescale Changes Image Size

Sat, 20 Nov 2010 21:18:39 +0000

When using liquid rescale on a layer.

Select a layer ->Layer->Liquid rescale-> Change width->Click ok

The image is now resized to be the size of the changed layer. Big pain.

"gimp-lqr-plugin.exe has encountered a problem....." [FIXED]:

Fri, 17 Sep 2010 19:11:02 +0000

Bug Report:

I have GIMP 2.7.1 (Development Release), it is installed in
"C:\Program Files\GIMP 2.7\" while the _REGULAR_ GIMP (non-development) is in
"C:\Program Files\GIMP-2.7\" (Notice the "-" in the pathname). The dev version
does NOT have intl.dll so I had to copy it from the other directory. I think it may
be optional so the 'Installer' would need to check for it and NOT assume it is present.

1. I downloaded http://liquidrescale.wikidot.com/local--files/en:download-page-windows/gimp-lqr-plugin_0.7.1-liblqr_0.4.1_win32_setup-1.exe .
2. First the "Installer" said that GIMP was not installed but I could continue ONLY if I specified the Folder, I said it was in "C:\Program Files\GIMP 2.7" and the "Installer" completed properly.
3. When I started GIMP the 'pyconsole' ran to detect new plugins but ultimatley I got a message that said:

"
gimp-lqr-plugin.exe - Unable to Locate Component
(X) This application has failed to start because intl.dll was not found. Re-installing the application may fix this problem.
"

After copying the '.dll' from the non-dev to the dev's directory the plug-in shows up in the bottom of the Layer menu.

Rob

(PS: No reply required, WFM.)

Incorrect path for locale data on non-Unix systems: Re: Incorrect path for locale data on non-Unix systems

Sat, 21 Aug 2010 15:59:59 +0000

Hi Carlo,
your answer to Torstens suggestion isn't correct.
Every plugin automatically initiates those functions.
See: http://developer.gimp.org/api/2.0/libgimpbase/libgimpbase-gimpenv.html
Regards, Nick

Palette switching back to black when creating a preservation layer: Re: Palette switching back to black when creating a preservation layer

Fri, 11 Jun 2010 11:25:55 +0000

The intended behaviour is that the colour changes when entering in mask editing mode and goes back to the previous state when exiting that mode.

If this is what you're observing, then it's not a bug (and I believe that this behaviour makes sense).

If, however, the behaviour is different from this (and from what you see in the linux version, for example), please be more precise in the description, because I can't reproduce the bug, and I don't know what the problem might be.

Palette switching back to black when creating a preservation layer: Palette switching back to black when creating a preservation layer

Fri, 11 Jun 2010 08:50:08 +0000

Running lqr 0.7.1 on GIMP 2.6.8 on windows XP.
When I create a new preservation layer, the palette goes green then switches back to black. Unaware users may then paint the layer black instead of green.

"gimp-lqr-plugin.exe has encountered a problem....." [FIXED]: It Worked!

Mon, 07 Jun 2010 08:27:46 +0000

Thankyou so much CarloB!!! Your fix worked! It's great to have your plugin up and running. God Bless you!

Dave.

"gimp-lqr-plugin.exe has encountered a problem....." [FIXED]:

Sun, 06 Jun 2010 00:40:32 +0000

Thank you all for the feedback, I have found the problem and fixed it. The new release 0.7.1 is now available in the Windows download page.

Please, let me know if everything goes fine.

"gimp-lqr-plugin.exe has encountered a problem....." [FIXED]:

Sat, 05 Jun 2010 19:16:21 +0000

Thankyou Amel. I want to try what you said, but I don't know how to find older versions of the plugin on the website. Could you or CarloB show me where or how I can download vers. 0.6.1? Thankyou very much for all your help!!! Dave.

"gimp-lqr-plugin.exe has encountered a problem....." [FIXED]: Re: Mr

Fri, 04 Jun 2010 15:00:08 +0000

I tried to install version 0.7.0 on WinXP sp3. And then I have same situation as you. Then I uninstall ver. 0.7.0 and then install version 0.6.1. This version work fine. After that install version 0.7.0 over 0.6.1 and then version 0.7.0 also works fine.

I hope so that this help.

Sorry for my english.

"gimp-lqr-plugin.exe has encountered a problem....." [FIXED]: Mr

Fri, 04 Jun 2010 04:50:58 +0000

Hi CarloB, No, I never tried version 0.6.1, but I would like to give it a try. My XP Service Pack is 2 on the computer in question. (Although I know there is a newer Service Pack available, I have avoided having to mess with putting the computer on the internet.) Thanks very much for all the work you've accomplished in developing this advanced plugin and making it available for all.
Respectfully, Dave Kettrey

"gimp-lqr-plugin.exe has encountered a problem....." [FIXED]: Re: "gimp-lqr-plugin.exe has encountered a problem....."

Thu, 03 Jun 2010 07:55:15 +0000

I'm aware of this problem and I'll try to solve it as soon as possible.
In the meanwhile, avoid sending error reports via Windows, even if you're connected to the internet.

Now for some additional questions:

Did you test the previous version of the plugin, 0.6.1? Did it work?
What is the service pack version of your Windows XP?

"gimp-lqr-plugin.exe has encountered a problem....." [FIXED]: "gimp-lqr-plugin.exe has encountered a problem....."

Thu, 03 Jun 2010 07:46:20 +0000

I'm moving this report here:

Hello Carlos, I downloaded and installed your latest Windows release of this amazing plugin. I have GIMP 2.6.8 on Windows XP. The installation went well and gimp-lqr-plugin.exe is in the proper place in the plugins folder. But when I start GIMP, and it's "querying new plugins", a Microsoft Error Reporting dialogue pops up saying that "gimp-lqr-plugin.exe has encountered a problem and needs to close." I never send the error report because the computer I use is not connected to the internet, so after clicking "Don't Send", the dialoque closes and GIMP resumes a normal startup, but without Liquid Rescale showing in the Layers Menu. Do you have any ideas what could be causing this error condition? Thanks for your help and ideas!

Incorrect path for locale data on non-Unix systems: Re: Incorrect path for locale data on non-Unix systems

Sat, 20 Mar 2010 16:54:30 +0000

I'm aware of this problem. However, the solution you propose is not valid, since the built-in GIMP functions, like gimp_locale_directory, can only be used for the main GIMP program and plugins, not the ones provided by third parties like LqR.

Windows Installer should allow directory choice: Re: Windows Installer should allow directory choice

Sat, 20 Mar 2010 16:50:58 +0000

As explained in the installation instructions, the Windows exe's are not true installers, they're just self-extracting zip files. Thus, in the case you want to install in a non-standard location, all you need to do is open the "installer" with an archive extractor, like e.g. 7zip, and extract the files in the desired folder.

Incorrect path for locale data on non-Unix systems: Incorrect path for locale data on non-Unix systems

Tue, 12 Jan 2010 11:57:36 +0000

The plug-in uses hardcoded values for locating the locale data on the installation system, which only works properly on Unix'ish systems.
When run in a Windows environment, there is a big chance of the hardcoded value pointing to the wrong or even a missing directory.
To fix this, any hardcoded path should be replaced with a call to of one of the gimpenv functions.

In case of the LOCALEDIR, instead calling "gimp_locale_directory ()" is sufficient.

If other data directories are also used by the plug-in (e.g. for registering the help file), these may need to be constructed, e.g. through:
gchar *path, *uri;
path = g_build_filename (gimp_data_directory (), "help", PLUGIN_NAME, NULL);
uri = g_filename_to_uri (path, NULL, NULL);
g_free (path);
gimp_plugin_help_register (plugin_name, uri);
g_free (uri);

Windows Installer should allow directory choice: Windows Installer should allow directory choice

Sun, 10 Jan 2010 22:36:43 +0000

I was playing with GIMP 2.7 so have GIMP installed in several different, non-default, directories. The installer doesn't allow choice of where to install to so after install, I had to copy files from the GIMP-2.0 default directory to where the current version of GIMP was installed.

Minor problem but should be simple to fix..